Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,5 @@
"node": "^20.19.0 || >=22.12.0",
"pnpm": ">=9.0.0"
},
"packageManager": "pnpm@9.15.9",
"pnpm": {
"overrides": {
"vite": "catalog:",
"vitest": "catalog:"
}
}
"packageManager": "pnpm@9.15.9"
}
Comment on lines +40 to 41

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Restore the pnpm.overrides block here to ensure that vite and vitest are correctly overridden across the monorepo. Since you have defined the specific versions in the pnpm-workspace.yaml catalog, you can use "catalog:" here to automatically sync them.

Suggested change
"packageManager": "pnpm@9.15.9"
}
"packageManager": "pnpm@9.15.9",
"pnpm": {
"overrides": {
"vite": "catalog:",
"vitest": "catalog:"
}
}
}

6 changes: 3 additions & 3 deletions packages/varlet-cli/template/generators/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
"@varlet/ui": "workspace:*",
"@vue/test-utils": "2.4.6",
"@vue/runtime-core": "3.5.21",
"@vitest/coverage-istanbul": "4.1.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.18",
"@vitest/coverage-istanbul": "4.1.9",
"vitest": "4.1.9",
"clipboard": "^2.0.6",
"jsdom": "26.1.0",
"live-server": "^1.2.1",
"rattail": "^2.0.3",
"typescript": "5.6.3",
"vite-plus": "0.1.18",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1856",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a hardcoded pkg.pr.new URL in a template generator's package.json means any project generated by users of this CLI will be locked to this specific temporary commit build.

While this might be necessary for temporary testing of this PR, please ensure this is replaced with a proper npm version range (e.g., ^0.2.0 or 0.2.0) before merging or releasing, to avoid breaking downstream users when the temporary build is cleaned up or if they require a stable release.

"vue": "3.5.21",
"vue-router": "4.5.1"
},
Expand Down
Loading
Loading