Skip to content

chore: upgrade vite-plus to 0.2.1#20

Draft
fengmk2 wants to merge 1 commit into
mainfrom
chore/upgrade-vite-plus-0.2.1
Draft

chore: upgrade vite-plus to 0.2.1#20
fengmk2 wants to merge 1 commit into
mainfrom
chore/upgrade-vite-plus-0.2.1

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Problem

vite-plus v0.2.1 consumes upstream Vitest directly. The @voidzero-dev/vite-plus-test wrapper is gone; vitest now comes in transitively through vite-plus.

Changes

  • Catalog: vite-plus 0.1.24 -> 0.2.1, vite -> @voidzero-dev/vite-plus-core@0.2.1 (core override kept).
  • Catalog: vitest -> upstream 4.1.9 (was the vite-plus-test alias); @vitest/coverage-istanbul 4.1.6 -> 4.1.9 (this repo uses vitest directly).
  • Dropped the vitest peerDependencyRules accommodations for the wrapper/old vitest.
  • Repointed scripts/lib/vitest-blob-timings.mjs at the vitest package (blob-parser chunk is identical; the wrapper was just vitest re-bundled).

Verification

No wrapper references remain outside node_modules; the lockfile resolves to a single vitest@4.1.9. vp check passes (format + lint/types). vp test run --project unit is 6907/6909; the 2 failures are pre-existing environment flakes, not from this change: asset-prefix (.vite temp-file race, passes on isolated retry) and font-google (real Google Fonts fetch against a hardcoded 15s timeout, slow on this network).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies in pnpm-workspace.yaml, transitioning from the custom @voidzero-dev/vite-plus-test package to upstream vitest (v4.1.9), and updates vite and vite-plus to v0.2.1. Consequently, scripts/lib/vitest-blob-timings.mjs is updated to resolve the vitest package directly using createRequire and load its bundled blob parser. Feedback suggests wrapping the readdir call for chunksDir in a try-catch block to handle potential errors gracefully and provide a clearer error message if the directory is missing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread scripts/lib/vitest-blob-timings.mjs Outdated
v0.2.1 consumes upstream Vitest directly: the @voidzero-dev/vite-plus-test wrapper is removed and vitest now comes in transitively through vite-plus.

- catalog: vite-plus 0.1.24 -> 0.2.1, vite -> @voidzero-dev/vite-plus-core@0.2.1
- catalog: vitest -> upstream 4.1.9 (was the vite-plus-test alias), @vitest/coverage-istanbul 4.1.6 -> 4.1.9
- drop the vitest peerDependencyRules accommodations for the wrapper/old vitest
- decode Vitest's flatted blob format directly in scripts/lib/vitest-blob-timings.mjs (the removed wrapper bundled the parser this script previously reached into)
@fengmk2 fengmk2 force-pushed the chore/upgrade-vite-plus-0.2.1 branch from bb8fc41 to 78daf8e Compare June 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant