Skip to content

chore(deps): bump vite-plus to v0.2.0#9

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-0.2.0
Draft

chore(deps): bump vite-plus to v0.2.0#9
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-0.2.0

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg.pr.new prerelease build for v0.2.0.

Updated where applicable:

  • vite-plus -> pkg.pr.new build
  • vite (alias/override -> @voidzero-dev/vite-plus-core)
  • vitest pinned to bundled 4.1.9 (the @voidzero-dev/vite-plus-test wrapper was removed upstream; vitest is now plain upstream)
  • minimumReleaseAge enabled with vite-plus packages excluded (pnpm/bun/npm as applicable)

Also added a pull_request trigger (branches: main) to .github/workflows/test.yml so CI runs on this PR.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this Jun 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates package dependencies in the pnpm lockfile and workspace configuration, replacing several @voidzero-dev packages with specific build URLs and pinning vitest to version 4.1.9. It also introduces a minimumReleaseAge policy in pnpm-workspace.yaml. Feedback on these changes highlights that the 'catalog:' specifier should still be used in the overrides section to prevent duplicating version strings. Additionally, since minimumReleaseAge is measured in seconds, the current value of 60 only blocks packages for one minute and should be increased to a more secure duration like 24 hours (86400).

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
Comment on lines +12 to +13
vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856'
vitest: '4.1.9'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

You can continue using the 'catalog:' specifier for vite and vitest in the overrides section. This avoids duplicating the version/URL strings and ensures they stay in sync with the catalog definitions automatically when updated in the future.

  vite: 'catalog:'
  vitest: 'catalog:'

Comment thread pnpm-workspace.yaml
allowedVersions:
vite: '*'
vitest: '*'
minimumReleaseAge: 60

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In pnpm, the minimumReleaseAge setting is specified in seconds, not minutes or days. Setting it to 60 only blocks packages published within the last 1 minute, which provides very little protection against supply chain or typosquatting attacks.

Consider increasing this value to a more secure duration, such as:

  • 86400 (24 hours)
  • 172800 (48 hours)
  • 604800 (7 days)
minimumReleaseAge: 86400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant