Skip to content

chore: upgrade vite-plus to 0.1.16-alpha.4 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: upgrade vite-plus to 0.1.16-alpha.4 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vite-hooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
vp lint
vp staged

@gemini-code-assist gemini-code-assist Bot Apr 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Running both vp lint and vp staged in the pre-commit hook is likely redundant. vp staged is typically used to run checks only on changed files to speed up the commit process. If vp lint performs a full project check, it should be removed from the pre-commit hook to avoid duplicate work and improve performance.

1,237 changes: 299 additions & 938 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@
"nodejs-file-downloader": "^4.13.0",
"npm-run-all": "^4.1.5",
"typescript": "^5.8.3",
"vite-plus": "latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vite-plus": "0.1.16-alpha.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.16-alpha.4"
},
"overrides": {
"js-yaml": "^4.1.1",
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.16-alpha.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.16-alpha.4"
},
"packageManager": "npm@11.11.1"
}
1 change: 1 addition & 0 deletions packages/plugin-runtime-types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"lib": ["es2021", "dom"],
"declaration": true,
"declarationDir": "./lib",
"rootDir": "./src",
"outDir": "./lib",
"strict": true,
"types": ["node"]
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-runtime/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"moduleResolution": "node16",
"resolveJsonModule": true,
"sourceMap": true,
"rootDir": "./src",
"outDir": "build"
},
"include": ["src"]
Expand Down
4 changes: 2 additions & 2 deletions src-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@
"postcss": "^8.5.6",
"postcss-nesting": "^13.0.2",
"tailwindcss": "^3.4.17",
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.16-alpha.4",
"vite-plugin-static-copy": "^3.3.0",
"vite-plugin-svgr": "^4.5.0",
"vite-plus": "latest"
"vite-plus": "0.1.16-alpha.4"
}
}
1 change: 0 additions & 1 deletion src-web/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"useDefineForClassFields": true,
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": false,

@gemini-code-assist gemini-code-assist Bot Apr 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of just removing "esModuleInterop": false, it is recommended to set it to true. This is the modern standard for TypeScript projects, ensuring better compatibility with CommonJS modules and simplifying the configuration as it automatically enables allowSyntheticDefaultImports.

Suggested change
"esModuleInterop": false,
"esModuleInterop": true,

"allowSyntheticDefaultImports": true,
"strict": true,
"noUncheckedIndexedAccess": true,
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"useDefineForClassFields": true,
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": false,

@gemini-code-assist gemini-code-assist Bot Apr 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of just removing "esModuleInterop": false, it is recommended to set it to true. This is the modern standard for TypeScript projects, ensuring better compatibility with CommonJS modules and simplifying the configuration as it automatically enables allowSyntheticDefaultImports.

Suggested change
"esModuleInterop": false,
"esModuleInterop": true,

"allowSyntheticDefaultImports": true,
"strict": true,
"noUncheckedIndexedAccess": true,
Expand Down
3 changes: 3 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { defineConfig } from "vite-plus";

export default defineConfig({
staged: {
"*": "vp check --fix",

@gemini-code-assist gemini-code-assist Bot Apr 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a broad glob like "*" in the staged configuration will run vp check --fix on every staged file, including non-code assets (images, etc.). It is better to restrict this to relevant file extensions to avoid unnecessary processing.

Suggested change
"*": "vp check --fix",
"**/*.{ts,js,tsx,json,css}": "vp check --fix",

},
lint: {
ignorePatterns: ["npm/**", "crates/yaak-templates/pkg/**", "**/bindings/gen_*.ts"],
options: {
Expand Down
Loading