Skip to content

chore: upgrade vite-plus to 0.1.17-alpha.4 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: upgrade vite-plus to 0.1.17-alpha.4 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e3e31f
chore: upgrade vite-plus to 0.1.17-alpha.4
fengmk2 Apr 13, 2026
1beb56c
chore: bump to vite-plus 0.1.17-alpha.5
fengmk2 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vite-hooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
vp lint
vp staged
1,217 changes: 345 additions & 872 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@
"nodejs-file-downloader": "^4.13.0",
"npm-run-all": "^4.1.5",
"typescript": "^5.8.3",
"vite-plus": "latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vite-plus": "0.1.17-alpha.5",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.17-alpha.5"
},
"overrides": {
"js-yaml": "^4.1.1",
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.17-alpha.5",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.17-alpha.5"
},
"packageManager": "npm@11.11.1"
}
1 change: 1 addition & 0 deletions packages/plugin-runtime-types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"lib": ["es2021", "dom"],
"declaration": true,
"declarationDir": "./lib",
"rootDir": "./src",
"outDir": "./lib",
"strict": true,
"types": ["node"]
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-runtime/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"moduleResolution": "node16",
"resolveJsonModule": true,
"sourceMap": true,
"rootDir": "./src",
"outDir": "build"
},
"include": ["src"]
Expand Down
4 changes: 2 additions & 2 deletions src-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@
"postcss": "^8.5.6",
"postcss-nesting": "^13.0.2",
"tailwindcss": "^3.4.17",
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.17-alpha.5",
"vite-plugin-static-copy": "^3.3.0",
"vite-plugin-svgr": "^4.5.0",
"vite-plus": "latest"
"vite-plus": "0.1.17-alpha.5"
}
}
1 change: 0 additions & 1 deletion src-web/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"useDefineForClassFields": true,
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": false,
"allowSyntheticDefaultImports": true,

@gemini-code-assist gemini-code-assist Bot Apr 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For web projects, enabling esModuleInterop is standard practice to avoid runtime issues with CommonJS dependencies. Instead of just removing the explicit false value, consider setting it to true to align with modern TypeScript standards and ensure robust module interop.

Suggested change
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,

"strict": true,
"noUncheckedIndexedAccess": true,
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"useDefineForClassFields": true,
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": false,
"allowSyntheticDefaultImports": true,

@gemini-code-assist gemini-code-assist Bot Apr 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the explicit false value is a good cleanup, TypeScript still defaults esModuleInterop to false. In modern projects, especially those using Vite and React, it is highly recommended to set "esModuleInterop": true. This ensures better compatibility with CommonJS modules and provides a more consistent experience when importing libraries that don't have a default export. Since allowSyntheticDefaultImports is already enabled, setting esModuleInterop to true is the preferred way to handle these imports correctly at both compile-time and runtime.

Suggested change
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,

"strict": true,
"noUncheckedIndexedAccess": true,
Expand Down
3 changes: 3 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { defineConfig } from "vite-plus";

export default defineConfig({
staged: {
"*": "vp check --fix",
},
lint: {
ignorePatterns: ["npm/**", "crates/yaak-templates/pkg/**", "**/bindings/gen_*.ts"],
options: {
Expand Down
Loading