Open
Conversation
Just deleted the unnecessary factory runner
Factory pattern#51
…take string as input instead of enum
…take string as input instead of enum
New tests added
Owner
fengyuanyang
left a comment
fengyuanyang
left a comment
There was a problem hiding this comment.
hi , can you have a look on it
Comment on lines
+77
to
+82
| try { | ||
| animal = AnimalFactory.getAnimal("BAT"); | ||
| } | ||
| catch (Exception e) { | ||
| assertEquals(e.getClass(), IllegalArgumentException.class); | ||
| } |
Owner
There was a problem hiding this comment.
this block can be replaced with
assertThrows(IllegalArgumentException.class, () -> AnimalFactory.getAnimal("BAT"));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new tests and changed the way AnimalFactory took input (String instead of direct enum)