Create Linear Search Using Function in java#108
Open
manavbhikadiya wants to merge 1 commit intofengyuanyang:mainfrom
Open
Create Linear Search Using Function in java#108manavbhikadiya wants to merge 1 commit intofengyuanyang:mainfrom
manavbhikadiya wants to merge 1 commit intofengyuanyang:mainfrom
Conversation
Author
|
Linear Search |
Author
|
i have already added the solution. please accept my pull request. |
Owner
fengyuanyang
left a comment
fengyuanyang
left a comment
There was a problem hiding this comment.
i have already added the solution. please accept my pull request.
It's not only about the solution , we expect Test driven development , however I didn't see your unit tests here
| int x = 10; | ||
|
|
||
| // Function call | ||
| int result = search(arr, x); |
Owner
There was a problem hiding this comment.
Hi @manavbhikadiya
Thanks for your effort here , can you have a look on other tests,
We are ought to use unit tests here , not main method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.