fix(go): auth in wire tests, seed test failures on main#14760
fix(go): auth in wire tests, seed test failures on main#14760patrickthornton merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
SDK Generation Benchmark ResultsComparing PR branch against latest nightly baseline on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
Description
The fixtures
exhaustive/omit-empty-request-wrappersandgo-deterministic-orderingwere failing on main because of a stale generation; this fixes that, plus adds an extra prophylactic change toWireTestGenerator.tswherein actual auth options get generated whenendpoint.authis true.Testing
Tested that those two Go fixtures are indeed consistently failing on recent main runs (appears to have stemmed from here #14411, a PR that changed a shared util packages/commons/mock-utils/index.ts but didn't regenerate Go seed fixtures; and tested that this change fixes that.