Skip to content

fix(go): auth in wire tests, seed test failures on main#14760

Merged
patrickthornton merged 1 commit intomainfrom
patrick/go/seed-fix
Apr 8, 2026
Merged

fix(go): auth in wire tests, seed test failures on main#14760
patrickthornton merged 1 commit intomainfrom
patrick/go/seed-fix

Conversation

@patrickthornton
Copy link
Copy Markdown
Contributor

@patrickthornton patrickthornton commented Apr 8, 2026

Description

The fixtures exhaustive/omit-empty-request-wrappers and go-deterministic-ordering were failing on main because of a stale generation; this fixes that, plus adds an extra prophylactic change to WireTestGenerator.ts wherein actual auth options get generated when endpoint.auth is true.

Testing

Tested that those two Go fixtures are indeed consistently failing on recent main runs (appears to have stemmed from here #14411, a PR that changed a shared util packages/commons/mock-utils/index.ts but didn't regenerate Go seed fixtures; and tested that this change fixes that.

  • Unit tests added/updated
  • Manual testing completed

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

SDK Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-08T04:49:09Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
go-sdk square 280s 345s 294s +14s (+5.0%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-04-08T04:49:09Z). Trigger benchmark-baseline to refresh.

@patrickthornton patrickthornton changed the title fix(go): seed test failures on main fix(go): auth in wire tests, seed test failures on main Apr 8, 2026
@patrickthornton patrickthornton merged commit cc2932e into main Apr 8, 2026
90 checks passed
@patrickthornton patrickthornton deleted the patrick/go/seed-fix branch April 8, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants