Skip to content

fix(cli): ignore stale slug history in missing redirects check#15114

Merged
thesandlord merged 7 commits intomainfrom
anar/fer-9430-cli-docs-address-false-positives-from-missing-redirects
Apr 17, 2026
Merged

fix(cli): ignore stale slug history in missing redirects check#15114
thesandlord merged 7 commits intomainfrom
anar/fer-9430-cli-docs-address-false-positives-from-missing-redirects

Conversation

@kafkas
Copy link
Copy Markdown
Member

@kafkas kafkas commented Apr 17, 2026

Description

Linear ticket: Closes FER-9430

Fixes false positives in the missing-redirects check when FDR returns multiple historical slug mappings for the same pageId.

The rule now keeps only the most recent slug-table row per pageId before comparing published state against the local docs config. This makes the check resilient both to stale rows already present in FDR and to future FDR behavior where older mappings may be preserved intentionally for docs-site versioning.

Changes Made

  • Added keepLatestEntryPerPageId() to dedupe FDR markdown entries down to the latest slug per page before running redirect validation
  • Updated the missing-redirects rule and test suite to cover stale historical rows, changelog-style shared slugs, and real move/remove cases

Testing

  • Unit tests added/updated
  • Manual testing completed

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

@thesandlord thesandlord merged commit 458402d into main Apr 17, 2026
58 checks passed
@thesandlord thesandlord deleted the anar/fer-9430-cli-docs-address-false-positives-from-missing-redirects branch April 17, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants