You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds bidirectional clipboard sharing between all connected machines.
Clipboard sharing is enabled by default. To disable, add to ~/.config/lan-mouse/config.toml: enable_clipboard = false
A few things - we dont have to fix any of this right away:
I'm not a fan of polling the clipboard. This seems a bit wasteful and it seems like there should be a better way? How do clipboard monitoring tools do it?
Maybe, it would make sense to get the clipboard contents upon entering a client device? This would of course not synchronize the clipboard when copied though.
It might be worth having ClipboardEvent be a direct member of the input_capture::CaptureEvent enum instead of input_event::Event and split input_event::Event into input_event::{InputEvent,ClipboardUpdate} or something. This way we could drop the dummy implementations on all of the input_emulation backends that do not support clipboard sharing.
I would prefer to keep clipboard_monitor and clipboard_emulation out of the service struct and instead move them into the lan_mouse::emulation::Emulation / lan_mouse::capture::Capture structs respectively.
We should not need a ClipboardReceived Event on the emulation side and could instead handle it like any other emulation event.
ClipboardReceivedEvents coming from the input capture / connection via ICaptureEvent could then be send to the emulation via an additional function lan_mouse::emulation::Emulation::update_clipboard() and EmulationRequest::UpdateClipboard(ClipBoardEvent) in lan_mouse::emulation instead of being handled directly in the service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bidirectional clipboard sharing between all connected machines.
Clipboard sharing is enabled by default. To disable, add to
~/.config/lan-mouse/config.toml:enable_clipboard = false4KB max, no chunking, text only