Attach dialog to window#384
Conversation
| pending: VecDeque<(CaptureHandle, CaptureEvent)>, | ||
| } | ||
|
|
||
| #[derive(Clone, Debug)] |
There was a problem hiding this comment.
We have a type similar to this in ashpd, named WindowIdentifierType. Maybe we can make it public, currently it is behind a backend feature
| X11(u32), | ||
| } | ||
|
|
||
| impl Into<ashpd::WindowIdentifier> for WindowIdentifier { |
There was a problem hiding this comment.
Then this impl can go into ashpd itself
|
|
||
| // export TopLevel handle and send it to the service so that it can put the InpuCapture / RemoteDesktop | ||
| // windows on top of it using xdg-foreign. | ||
| window.connect_show(|window| { |
There was a problem hiding this comment.
We have a gtk feature for this, why not make use of it?
There was a problem hiding this comment.
Is that possible? How do I get the handle from the GtkWindowIdentifier for serialization?
There was a problem hiding this comment.
It implements Serialize/ToString but you will have to keep a ref to the ashpd type till the dialog is closed to not unexport the handle
There was a problem hiding this comment.
In that case I guess it would make sense to change bilelmoussaoui/ashpd#352 to take in the entire "wayland:{handle}" string?
There was a problem hiding this comment.
to not unexport the handle
I should probably do that as well
There was a problem hiding this comment.
In that case I guess it would make sense to change bilelmoussaoui/ashpd#352 to take in the entire
"wayland:{handle}"string?
Not if you make WindowIdentifierType public and you write a From trait impl for it.
feschber
force-pushed
the
attach-dialog-to-window
branch
2 times, most recently
from
72f4fa1 to
a5bdcd0
Compare
feschber
force-pushed
the
attach-dialog-to-window
branch
3 times, most recently
from
a9d76af to
c5d2b3c
Compare
feschber
force-pushed
the
attach-dialog-to-window
branch
3 times, most recently
from
8bd93fd to
5881ecd
Compare
feschber
force-pushed
the
attach-dialog-to-window
branch
from
5881ecd to
8ed6fe7
Compare
feschber
force-pushed
the
attach-dialog-to-window
branch
from
8ed6fe7 to
33b6b78
Compare
2 participants
This puts the dialog for input-capture on top of the main lan-mouse window.