Skip to content

Added A Minshare feature#14

Open
ParthKolekar wants to merge 1 commit into
ffledgling:masterfrom
ParthKolekar:minshare
Open

Added A Minshare feature#14
ParthKolekar wants to merge 1 commit into
ffledgling:masterfrom
ParthKolekar:minshare

Conversation

@ParthKolekar

Copy link
Copy Markdown

cleaned the previous commit
sending request from minshare branch, so that history is clean

@ParthKolekar

Copy link
Copy Markdown
Author

@ffledgling @nehaljwani

The use of the feature may be under debate, plus, this is crude patch, because dtella does not update minshare from 1 for the current setup.

@ffledgling

Copy link
Copy Markdown
Owner

Aren't global level values in a separate config.py file?

@ParthKolekar

Copy link
Copy Markdown
Author

There is no config.py that I see...
there is

bridge_config.py
push_dconfig.py
pull_dconfig.py

@ffledgling

Copy link
Copy Markdown
Owner

@ParthKolekar

Copy link
Copy Markdown
Author

@ffledgling
There is indeed one value I remember trying to set in the config, but the init set's the value to be 1 (1 byte) and the config is never read. The 1 byte stays until the end of time, and is not even changed ever.

I have allowed AGREED_UPON_MINSHARE var which is actually read by the and used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants