Fix 10#11
Open
dekobon wants to merge 4 commits into
Open
Conversation
Author
|
I've updated to use the AssertJ library. Sorry that I didn't catch that earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8
There was a lot more work done in this PR than I would have liked there to be. I was forced to base it off of my previous PR, so that I could act with the assumptions related to an empty path. There were a lot of assumptions that were tied to each other in how Paths were defined. I've continued to use the patterns established by the JVM's UnixPath behavior.
In this PR, I updated how toString() behaves for paths that have an empty rootSeparator (e.g. UnixPath) so that they don't output a String with an embedded "null" in them. I've also modified how endsWith() behaves so that it conforms to the expectations of UnixPath and doesn't throw an exception when trying to access an element of an array that is unavailable.
Please let me know if these PRs are welcome or if they are a nuisance. I'm actively developing an NIO plugin and I would like to get this project to a solid next release.