Skip to content

Optimize temporary local variable allocation #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fglock wants to merge 1 commit into from
Closed

Optimize temporary local variable allocation #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/org/perlonjava/codegen/EmitterMethodCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,12 +575,14 @@ private static byte[] getBytecodeInternal(EmitterContext ctx, Node ast, boolean
// Temporaries are allocated dynamically during bytecode emission via
// ctx.symbolTable.allocateLocalVariable(). We pre-initialize slots to ensure
// they're not in TOP state when accessed. Use a visitor to estimate the
// actual number needed based on AST structure rather than a fixed count.
// actual number needed based on AST structure.
// Add a modest buffer since visitor doesn't count all allocation sites.
int preInitTempLocalsStart = ctx.symbolTable.getCurrentLocalVariableIndex();
org.perlonjava.astvisitor.TempLocalCountVisitor tempCountVisitor =
org.perlonjava.astvisitor.TempLocalCountVisitor tempCountVisitor =
new org.perlonjava.astvisitor.TempLocalCountVisitor();
ast.accept(tempCountVisitor);
int preInitTempLocalsCount = Math.max(128, tempCountVisitor.getMaxTempCount() + 64); // Add buffer
int preInitTempLocalsCount = tempCountVisitor.getMaxTempCount() + 32; // Add 32-slot buffer
ctx.logDebug("Pre-initializing " + preInitTempLocalsCount + " temp locals");
for (int i = preInitTempLocalsStart; i < preInitTempLocalsStart + preInitTempLocalsCount; i++) {
mv.visitInsn(Opcodes.ACONST_NULL);
mv.visitVarInsn(Opcodes.ASTORE, i);
Expand Down