refactor: Split BytecodeCompiler and fix glob slot access#213
Merged
Conversation
Extracted compilation logic into separate, focused classes: - CompileOperator: Handles operator compilation (die, eval, require, package, etc.) - CompileBinaryOperator: Handles binary operator compilation (and/or, ternary, etc.) - CompileBinaryOperatorHelper: Helper methods for binary operator compilation - CompileAssignment: Handles assignment and declaration compilation Changed private fields to package-private to allow refactored classes access: - symbolTable, sourceName, sourceLine - bytecode, variableScopes, allDeclaredVariables - capturedVarIndices This refactoring improves maintainability by organizing code by responsibility while maintaining the same bytecode generation behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two improvements to the interpreter:
*X{HASH}in eval STRING, matching baseline compiler behaviorChanges
Glob Slot Access Fix
GLOB_SLOT_GETopcode (230) for direct glob slot accesshandleGeneralHashAccess()to detect*X{key}patternsexecuteGlobSlotGet()in SlowOpcodeHandlerBytecodeCompiler Refactoring
Extracted compilation logic into specialized classes:
Changed private fields to package-private for refactored class access:
Code Organization
Test Results
🤖 Generated with Claude Code