Skip to content

Fix interpreter shift/pop with default @_/@ARGV argument #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fglock merged 1 commit into from
Feb 23, 2026
Merged

Fix interpreter shift/pop with default @_/@ARGV argument #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 28 additions & 18 deletions src/main/java/org/perlonjava/backend/bytecode/CompileOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,19 +894,24 @@ public static void visitOperator(BytecodeCompiler bytecodeCompiler, OperatorNode
bytecodeCompiler.lastResultReg = rd;
} else if (op.equals("pop")) {
// Array pop: $x = pop @array or $x = pop @$ref
// operand: ListNode containing OperatorNode("@", IdentifierNode or OperatorNode)
if (node.operand == null || !(node.operand instanceof ListNode)) {
// operand: OperatorNode("@", ...) directly (default @_/@ARGV injected by parser)
// or ListNode containing OperatorNode("@", IdentifierNode or OperatorNode)
if (node.operand == null) {
bytecodeCompiler.throwCompilerException("pop requires array argument");
}

ListNode list = (ListNode) node.operand;
if (list.elements.isEmpty() || !(list.elements.get(0) instanceof OperatorNode)) {
bytecodeCompiler.throwCompilerException("pop requires array variable");
}

OperatorNode arrayOp = (OperatorNode) list.elements.get(0);
if (!arrayOp.operator.equals("@")) {
OperatorNode arrayOp;
if (node.operand instanceof OperatorNode directOp && directOp.operator.equals("@")) {
// Direct OperatorNode("@", ...) - default array case
arrayOp = directOp;
} else if (node.operand instanceof ListNode list && !list.elements.isEmpty()
&& list.elements.get(0) instanceof OperatorNode listOp
&& listOp.operator.equals("@")) {
// ListNode-wrapped OperatorNode("@", ...) - explicit array case
arrayOp = listOp;
} else {
bytecodeCompiler.throwCompilerException("pop requires array variable: pop @array");
return;
}

int arrayReg = -1; // Will be assigned in if/else blocks
Expand Down Expand Up @@ -953,19 +958,24 @@ public static void visitOperator(BytecodeCompiler bytecodeCompiler, OperatorNode
bytecodeCompiler.lastResultReg = rd;
} else if (op.equals("shift")) {
// Array shift: $x = shift @array or $x = shift @$ref
// operand: ListNode containing OperatorNode("@", IdentifierNode or OperatorNode)
if (node.operand == null || !(node.operand instanceof ListNode)) {
// operand: OperatorNode("@", ...) directly (default @_/@ARGV injected by parser)
// or ListNode containing OperatorNode("@", IdentifierNode or OperatorNode)
if (node.operand == null) {
bytecodeCompiler.throwCompilerException("shift requires array argument");
}

ListNode list = (ListNode) node.operand;
if (list.elements.isEmpty() || !(list.elements.get(0) instanceof OperatorNode)) {
bytecodeCompiler.throwCompilerException("shift requires array variable");
}

OperatorNode arrayOp = (OperatorNode) list.elements.get(0);
if (!arrayOp.operator.equals("@")) {
OperatorNode arrayOp;
if (node.operand instanceof OperatorNode directOp && directOp.operator.equals("@")) {
// Direct OperatorNode("@", ...) - default array case
arrayOp = directOp;
} else if (node.operand instanceof ListNode list && !list.elements.isEmpty()
&& list.elements.get(0) instanceof OperatorNode listOp
&& listOp.operator.equals("@")) {
// ListNode-wrapped OperatorNode("@", ...) - explicit array case
arrayOp = listOp;
} else {
bytecodeCompiler.throwCompilerException("shift requires array variable: shift @array");
return;
}

int arrayReg = -1; // Will be assigned in if/else blocks
Expand Down