Fix wantarray void context in eval STRING#232
Merged
Conversation
The VOID-to-SCALAR promotion in BytecodeCompiler.compile() was wrong. It caused wantarray() inside an eval STRING called in void context to return false (scalar) instead of undef (void). Fix: remove the promotion entirely, passing the true outer context unchanged — exactly as the JVM compiler does in EmitEval.java (emitterVisitor.ctx.contextType passed as-is to evalStringWithInterpreter). Result: op/eval.t now passes 153/153 in both JVM and interpreter modes.
fglock
added a commit
that referenced
this pull request
Mar 3, 2026
Fix wantarray void context in eval STRING
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the erroneous VOID-to-SCALAR promotion in BytecodeCompiler.compile(). The JVM compiler (EmitEval.java) passes ctx.contextType unchanged to evalStringWithInterpreter -- the bytecode compiler now does exactly the same. This fixes wantarray() inside eval STRING called in void context returning false (scalar) instead of undef (void). Result: op/eval.t passes 153/153 in both JVM and interpreter modes.