Fix wantarray void context in eval STRING#234
Closed
fglock wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded — the wantarray fix is included in PR #233 which has been merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EvalStringHandler.evalString() was hardcoding RuntimeContextType.SCALAR when executing the eval body, so wantarray() inside eval STRING always returned false (scalar) regardless of the actual call site context.\n\nFix: read registers[2] (the outer wantarray set by BytecodeInterpreter) and pass it as callContext to evalString() and apply(), so wantarray() inside the eval body correctly returns undef (void), false (scalar), or true (list) matching the outer call site.\n\nResult: op/eval.t passes 153/153 in both JVM and interpreter modes.