Fix interpreter eval regressions: bare block, doFile, list assignment validation#235
Merged
Merged
Conversation
… validation
- For3Node isSimpleBlock: preserve lastResultReg in non-VOID context
fixes eval '{ q,bar, }', eval '{ q=bar= }', eval '{ qq=bar= }' (comp/parser.t 36,38,40)
- Add DO_FILE opcode (340): compiler emit + interpreter handler + disassembler
fixes 'do FILE' inside eval STRING (op/do.t)
- CompileAssignment: call LValueVisitor.getContext() on ListNode LHS
fixes eval q{($a ? $x : ($y)) = 5} error propagation (comp/parser.t 53)
- Add SET_PACKAGE/PUSH_PACKAGE/POP_PACKAGE/DO_FILE disassembler cases
- Add POP_PACKAGE no-op interpreter handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regressions when
JPERL_EVAL_USE_INTERPRETER=1is enabled.Changes
1. Fix For3Node bare block value propagation (BytecodeCompiler.java)
{ q,bar, },{ q=bar= },{ qq=bar= }in eval STRING crashed with null pointerisSimpleBlockpath unconditionally setlastResultReg = -12. Add DO_FILE opcode 340 (Opcodes, CompileOperator, BytecodeInterpreter)
do FILEinside eval STRING threw "Unsupported operator: doFile"3. CompileAssignment: validate ListNode LHS with LValueVisitor (CompileAssignment.java)
eval q{($a ? $x : ($y)) = 5}silently succeeded instead of setting $@LValueVisitor.getContext()on ListNode LHS before compiling assignment4. Disassembler cases (InterpretedCode.java)
5. POP_PACKAGE + DO_FILE interpreter handlers (BytecodeInterpreter.java)
Testing
make cd perl5_t/t JPERL_EVAL_USE_INTERPRETER=1 ../../jperl comp/parser.t JPERL_EVAL_USE_INTERPRETER=1 ../../jperl op/do.t