Fix interpreter eval regressions 3#237
Closed
fglock wants to merge 3 commits into
Closed
Conversation
…tainer - OpcodeHandlerExtended.executeChop: use polymorphic .chop() instead of hard-casting to RuntimeScalar - fixes chop on arrays - CompileOperator each: force LIST context on operand so %h stays a RuntimeHash rather than being converted to ARRAY_SIZE (scalar size). Mirrors JVM handleEach which uses RuntimeContextType.LIST. - MiscOpcodeHandler: handle EACH before the RuntimeList cast since EACH now receives the container (RuntimeHash/RuntimeArray) directly
…h/chop - CompileAssignment: handle '*' as glob lvalue (e.g. 'foo'->** = 'bar'->**) Fixes: op/postfixderef.t tests 27-29 (glob access syntax) - BytecodeInterpreter DEREF: always call scalarDeref() so non-reference types (IO, FORMAT, etc.) correctly throw 'Not a SCALAR reference' Fixes: op/postfixderef.t tests 59, 63 - CompileOperator each: force LIST context on operand so %h remains a RuntimeHash instead of being converted to ARRAY_SIZE via scalar context Fixes: op/lex_assign.t test 86 (each %h inside scalar assignment) - OpcodeHandlerExtended.executeChop: use polymorphic .chop() instead of hard-casting to RuntimeScalar - MiscOpcodeHandler: handle EACH before RuntimeList cast since EACH now receives the container (RuntimeHash/RuntimeArray) directly
fglock
force-pushed
the
fix-interpreter-eval-regressions-3
branch
from
6aeee27 to
fa477fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.