Fix postfix deref eval/interpreter regressions and JVM ->%[]#238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several postfix dereference regressions.
->%[...](returns alternating index/value pairs).*EXPR = ..., e.g."mysubalias"->** = ...) by compiling the glob expression and emittingSTORE_GLOB.->**on*STDOUT{IO}) by creating a temporary glob when the scalar holds aRuntimeIO(handles bothGLOBandGLOBREFERENCErepresentations), preventingClassCastException.DEREF_HASHand guard string pool lookups.->%{...}/->%[...]) and interpreter opcode for hash key/value slices.Repro
->%[...]:perl5_t/t/op/postfixderef.tline 317JPERL_EVAL_USE_INTERPRETER=1 perl5_t/t/op/postfixderef.tNotes
This PR is a checkpoint; remaining eval-string interpreter differences are still being worked on (e.g. tests 70-71, 36, and postderef_qq interpolation cases under
JPERL_EVAL_USE_INTERPRETER=1).