Fix duplicate opcodes and update check_opcodes.pl#272
Merged
Conversation
- OP_POW and ALARM_OP both had opcode 155; OP_POW reassigned to 310 - Renumbered 284+ block to be contiguous (0..372, no gaps) - Updated check_opcodes.pl --renumber to fix duplicates by assigning new numbers to later occurrences using first available gap, then compacting the 284+ block as before Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OP_POWandALARM_OPboth had value 155;OP_POWreassigned to 310check_opcodes.pl --renumberto automatically fix duplicates by assigning new numbers to later occurrences using the first available gap, then compacting the 284+ blockTest plan
perl dev/tools/check_opcodes.pl Opcodes.javareports no duplicates, no gapsmvn package -DskipTestsbuilds successfullymvn test— all 154 unit tests passGenerated with Devin