Reduce execute() bytecode size and improve error messages#274
Merged
Conversation
Update class path from org.perlonjava.interpreter to org.perlonjava.backend.bytecode after package reorganization. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
fglock
force-pushed
the
improve-croak-error-messages
branch
from
e8b15c2 to
e522ef9
Compare
…assembler mappings
Reduce BytecodeInterpreter.execute() from 12007 to 7137 bytes (under 7500
JVM JIT limit) by extracting 84 inline case blocks into individual static
methods in new InlineOpcodeHandler.java.
Convert all switch statements to arrow-style (case X -> {}) for clarity
and to eliminate break statements.
Add comments explaining the nested try/catch/finally structure
(outer try for cleanup, inner try for Perl eval/die semantics).
Also add 76 missing opcode mappings to InterpretedCode disassembler and
remove dead executeArithmetic() method (326 lines).
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <noreply@cognition.ai>
fglock
force-pushed
the
improve-croak-error-messages
branch
from
e522ef9 to
407c7c0
Compare
Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BytecodeInterpreter.execute()into newInlineOpcodeHandler.java, reducing method size from 12007 to 7137 bytes (under 7500 JVM JIT compilation limit)InterpretedCodedisassemblerexecuteArithmetic()method (326 lines)check-bytecode-size.shfor renamed package path$#check to allow special array names ($#+,$#-,$#{^CAPTURE})Test plan
./gradlew classesbuilds successfullybash dev/tools/check-bytecode-size.shreports all methods under limit./gradlew classes testUnitParallel --parallel shadowJarall tests passGenerated with Devin