Interpreter improvements: extract opcodes, arrow syntax, simplify LOAD_STRING#275
Merged
Conversation
Remove redundant cache-check optimization that compared the existing register value before allocating. Benchmarking on ExifTool CanonRaw.t showed no measurable difference — the String.equals() cost offsets the saved allocation. Also improve LOAD_BYTE_STRING javadoc in Opcodes.java. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BytecodeInterpreter.execute()into newInlineOpcodeHandler.java, reducing method size from 12007 to 7137 bytes (under 7500 JVM JIT limit)case X -> {}) for clarity, eliminating break statementsInterpretedCodedisassemblerexecuteArithmetic()method (326 lines)check-bytecode-size.shfor renamed package path$#check to allow special array names ($#+,$#-,$#{^CAPTURE})Test plan
./gradlew classesbuilds successfullybash dev/tools/check-bytecode-size.sh— all methods under limit./gradlew classes testUnitParallel --parallel shadowJar— all tests passGenerated with Devin