Optimize interpreter for INTEGER type operations#283
Merged
Conversation
Add fast-paths for common operations when both operands are INTEGER: - InterpreterState: O(1) PC updates using mutable array instead of pop/push - BitwiseOperators: Skip type checks for &, |, ^, <<, >> - MathOperators: Skip blessedId/getNumber for +, -, * - CompareOperators: Skip blessedId/getNumber for <, <=, >, >=, ==, != Profile-guided optimization based on JFR analysis of life_bitpacked.pl. Eliminates overhead from getDefinedBoolean(), looksLikeNumber(), and ArrayDeque operations in the hot path. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Profile-guided optimizations for the bytecode interpreter, targeting INTEGER type operations:
ArrayDequeto direct array mutation (O(1))&,|,^,<<,>>that skip type checks when both operands are INTEGER+,-,*that skipblessedId()andgetNumber()calls<,<=,>,>=,==,!=that skipblessedId()andgetNumber()callsProfile Results (before → after)
InterpreterState.setCurrentPcgetDefinedBooleanArrayDeque.push/addFirstlooksLikeNumberBenchmark (life_bitpacked.pl, 3000 generations, 100x100 grid)
The interpreter is now ~2.3x slower than the JVM backend, which is reasonable for an interpreter.
Test plan
Generated with Devin