Optimize method call performance with inline cache and setFromList fast path#285
Merged
Conversation
…st path - Add inline method cache in RuntimeCode.callCached() for monomorphic call sites - Add setFromList fast path for common `my ($a, $b) = @_` pattern - Add RuntimeArray constructor with initial capacity to reduce ArrayList growth - Fix hasIsaChanged() to compare content instead of identity+size (fixes MRO regressions) - Fix setFromList fast path to copy RHS values before assignment (fixes aliasing in chained assignments) Performance improvement: ~300/s -> ~460-490/s (~55% faster) Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
Explain how monomorphic call site caching works for method dispatch optimization. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeCode.callCached()for monomorphic call sitessetFromListfast path for commonmy ($a, $b) = @_patternRuntimeArrayconstructor with initial capacity to reduce ArrayList growthhasIsaChanged()to compare content instead of identity+size (fixes MRO regressions)setFromListfast path to copy RHS values before assignment (fixes aliasing in chained assignments)Performance improvement: ~300/s → ~460-490/s (~55% faster)
Test plan
($a,$b) = ($b,$a) = ($a,$b)works correctlyGenerated with Devin