Fix caller() line number bug for deferred subroutine compilation#336
Merged
Conversation
Both documents verified against current test results: - Log::Log4perl: 18/700 subtests failing (6/73 programs) - CPAN client: Phase 9 complete, jcpan fully functional All remaining Log4perl failures are documented architectural limitations (caller line numbers, DESTROY, Safe.pm, source filters). Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
Root cause: ByteCodeSourceMapper.saveSourceLocation() used getLineNumber() which has a forward-only cache that returns stale values for out-of-order token access during deferred subroutine compilation. Fix: Use getLineNumberAccurate() which always counts from file start, safe for random access. Results: - Log::Log4perl t/024WarnDieCarp.t: 8 failures → 1 failure - Total Log4perl failures: 18/700 → 11/700 subtests Files: - ByteCodeSourceMapper.java: Use accurate line number calculation - caller_line_number_fix.md: Detailed design document - caller_line_number.t: Unit tests for caller() line numbers - log4perl-compatibility.md: Updated status Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
caller() Line Number Fix
Root cause:
ByteCodeSourceMapper.saveSourceLocation()usedgetLineNumber()which has a forward-only cache. When subroutines are compiled out-of-order (deferred closure compilation), the cache returned stale values from the end of the file.Fix: Changed to
getLineNumberAccurate()which always counts from the beginning, safe for random access.Results
Files Changed
src/main/java/org/perlonjava/backend/jvm/ByteCodeSourceMapper.java- The fixsrc/test/resources/unit/caller_line_number.t- Unit tests (8 tests)dev/design/caller_line_number_fix.md- Detailed design documentdev/design/log4perl-compatibility.md- Updated statusdev/design/cpan_client.md- Verified statusTest Plan
./jperl src/test/resources/unit/caller_line_number.tmake./jcpan -t Log::Log4perlGenerated with Devin