Fix stash deletion not removing CODE refs properly#377
Merged
Conversation
This fixes a bug where delete ${\042Foo::\042}{bar} would not properly
remove the stash entry when using the ${BLOCK}{key} syntax.
Changes:
- JVM backend (Dereference.java): Fix handleHashElementOperator to use
the hashOperation parameter for ${BLOCK}{key} patterns. Previously
it always called hashDerefGet regardless of delete/exists operations.
- Interpreter (CompileExistsDelete.java): Fix resolveHashFromBinaryOp
to compile operands in SCALAR context to avoid -1 register errors.
Note: Stash deletion removes the stash entry but compiled subroutine
references continue to work, matching Perl CV caching behavior.
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
0f1682f to
55a7bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug where
delete ${"Foo::"}{bar}would not properly remove the stash entry when using the${BLOCK}{key}syntax.Root Causes Fixed
JVM Backend (
Dereference.java): ThehandleHashElementOperatormethod for${BLOCK}{key}patterns always calledhashDerefGet/hashDerefGetNonStrictregardless of whether the operation was "get", "delete", or "exists".Interpreter (
CompileExistsDelete.java): TheresolveHashFromBinaryOpmethod didn't compile operands in SCALAR context, causing -1 register errors when the operand was a BlockNode.Test Case
Note: Stash deletion removes the stash entry but compiled subroutine references continue to work (matching Perl's CV caching behavior).
Test plan
Generated with Devin