WIP: fix 'Subroutine pipe redefined' warning in FileHandle.pm#428
Merged
Conversation
The `sub pipe` function was defined twice in FileHandle.pm: - Lines 41-46: early definition added to ensure defined(&pipe) returns true before the IO::Handle import filter on line 52 - Lines 103-108: the original definition that was never removed This caused a "Subroutine pipe redefined" warning when warnings were enabled (e.g. via jcpan -j 8 -t DateTime::Format::ICal). Remove the second (redundant) definition. The early definition at lines 41-46 is sufficient and correctly placed. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sub pipedefinition inFileHandle.pmthat causedSubroutine pipe redefined at jar:PERL5LIB/FileHandle.pm line 109warningRoot Cause
sub pipewas defined twice insrc/main/perl/lib/FileHandle.pm:defined(&pipe)returns true before theIO::Handle->import()filter on line 52, preventing IO::Handle from overwriting itWhen warnings were enabled (e.g. via
jcpan -j 8 -t DateTime::Format::ICal), the second definition triggered the redefinition warning.Fix
Removed the second (redundant)
sub pipedefinition and its outdated comment block. The early definition at lines 41–46 is sufficient and correctly placed before the import guard.Test plan
makepasses (build + all unit tests)./jcpan -j 8 -t DateTime::Format::ICalno longer shows the warningGenerated with Devin