WIP: fix Storable empty STORABLE_freeze return cancels hooks#429
Merged
Conversation
When deleting a stash namespace entry (key ending with '::'),
RuntimeStash.deleteGlob() was a no-op because it computed
fullKey = 'main::Foo::' but symbols are stored as 'Foo::bar'.
The exact-key lookup found nothing and returned early.
Fix: detect namespace keys and perform prefix-based removal from
all global maps (globalCodeRefs, globalVariables, globalArrays,
globalHashes, globalIORefs, globalFormatRefs) plus pinnedCodeRefs.
This fixes spurious 'Subroutine ACTION_foo redefined' warnings in
Module::Build t/help.t, and makes Foo->can('bar') correctly
return false after delete $::{'Foo::'}.
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Per Perl 5 Storable semantics, when STORABLE_freeze returns an empty
list, the hook is cancelled and default serialization is used instead.
This fixes DateTime::Infinite::Past/Future which define
`sub STORABLE_freeze {return}` to opt out of hooks.
Fixed in three codepaths:
- serializeBinary(): falls back to SX_BLESS default serialization
- deepClone(): falls back to regular deep-copy
- convertToYAMLWithTags(): falls back to !!perl/hash: serialization
Fixes DateTime t/23storable.t (20/20 tests now pass).
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: Storable empty
STORABLE_freezereturn now cancels hooks — Per Perl 5 Storable semantics, whenSTORABLE_freezereturns an empty list, the hook is cancelled and Storable falls back to default serialization. This is used byDateTime::Infinitewhich definessub STORABLE_freeze {return}to opt out of hooks.Fixed in three codepaths:
serializeBinary(): falls back toSX_BLESSdefault serializationdeepClone(): falls back to regular deep-copyconvertToYAMLWithTags(): falls back to!!perl/hash:serializationTest plan
makepasses (all unit tests)t/23storable.t: 20/20 tests pass (was 5/20 + crash)./jcpan -t DateTime: all 51 test files pass, 3589 subtestsGenerated with Devin