feat: bundle CPAN Text::CSV 2.06 with Text::CSV_PP backend#462
Merged
Conversation
fglock
changed the title
Add 40 original CPAN Text::CSV 2.06 test files to src/test/resources/module/Text-CSV/ for testing the bundled Java-backed Text::CSV implementation. Initial Text::CSV.pm improvements: - Add version(), status(), error_input(), is_pp(), is_xs(), module() - Add attribute validation in new() with known attribute allowlist - Add global error state for class-method error_diag() - Fix new() to handle object-method calls (ref $class || $class) - Fix quote_char/sep_char setters to accept undef - Add attribute aliases: sep, quote, escape, quote_always, verbose_diag Baseline: 2/40 tests pass. Plan documented in dev/modules/text_csv_bundled_tests_plan.md Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Replace the custom Java-backed Text::CSV.pm with the official CPAN Text::CSV 2.06 wrapper + Text::CSV_PP (pure Perl) implementation. Architecture: - Text::CSV.pm: CPAN 2.06 thin wrapper (146 lines, replaces 632-line custom) - Text::CSV_PP.pm: CPAN pure-Perl CSV implementation (6454 lines) - Text::CSV_XS.pm: Stub inheriting from CSV_PP with VERSION 1.61 Key changes: - Disabled TextCsv.java XS registration (now a no-op) - Added DataSection.reset() to fix __DATA__/__END__ stale state between JUnit test runs - Installed PublicMethods in CSV_XS stash so CSV.pm alias lookup works - Added lib/Text/CSV_PP.pm symlink in test resources Test results: 38/38 included CPAN tests pass - Excluded: 00_pod.t (needs Test::Pod), 70_rt.t (non-UTF-8 bytes) - All 113 unit tests in text_csv.t continue to pass Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
fglock
force-pushed
the
feature/text-csv-bundled-tests
branch
from
125c4f1 to
9f43104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the custom Java-backed Text::CSV.pm with the official CPAN Text::CSV 2.06 wrapper + Text::CSV_PP (pure Perl) implementation. This gives us a complete, spec-compliant CSV module that passes 38/40 CPAN test files.
Architecture
Key Changes
Test Results
Test plan
Generated with Devin