fix: B module improvements and do FILE $@ fix for Future 0.52 compatibility#465
Merged
Conversation
Analysis of `./jcpan -t Future` results: 36/56 test programs pass,
105/763 subtests fail. Root causes identified:
- P0: B::SV::REFCNT returns 0 instead of 1 (~100 subtests)
- P1: B::OP::next returns undef instead of B::NULL (4 crashes)
- P2: DESTROY not implemented (3 subtests, JVM limitation)
- P3: $@ leakage after dies{} (1 crash)
Fix plan: Phase 1 (REFCNT=1) and Phase 2 (B::NULL) are trivial
one-line changes that should fix ~60 subtests and 4 crashes.
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Three fixes that improve Future 0.52 compatibility from 36/56 to 41/56 test programs passing (105 -> 32 failing subtests): 1. B::SV::REFCNT returns 1 instead of 0, aligning with Internals::SvREFCNT and Devel::Peek::SvREFCNT stubs 2. B::OP::next returns B::NULL (not undef) to terminate optree walks correctly. Added B::COP class with file/line methods and B::CV::START now returns B::COP for proper introspection 3. do FILE now clears $@ after successful execution, matching Perl semantics where do FILE behaves like eval STRING Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
fglock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes that improve Future 0.52 compatibility from 36/56 to 41/56 test programs passing (105 -> 32 failing subtests, 70% reduction):
1. B::SV::REFCNT returns 1 (was 0)
Aligns with
Internals::SvREFCNTandDevel::Peek::SvREFCNTwhich already return 1. Fixes ~73 subtests whereTest2::Tools::Refcount::is_oneref()was failing.2. B module optree walking fixes
B::OP::nextreturnsB::NULL(wasundef) to terminate optree walks correctlyB::COPclass withfile/linemethods for proper introspectionB::CV::STARTreturnsB::COPso code like Future.pm'sCvNAME_FILE_LINE()worksB::NULL::nextreturns self to prevent infinite loopsThis eliminates 4 test crashes (exit 255) where Future.pm called
$cop->fileon undef.3.
do FILEclears $@ after successful executionPerl's$@ on success. PerlOnJava was not clearing $ @ after successful execution, causing $@ from inner
do FILEbehaves likeeval STRINGand clearseval { die ... }blocks to leak to the caller.Remaining failures (all unfixable JVM limitations)
Test plan
makepasses (all unit tests)./jcpan -t Futureresults: 41/56 programs pass, 32/778 subtests failGenerated with Devin