docs: Perl::Tidy test support plan#468
Closed
fglock wants to merge 1 commit into
Closed
Conversation
Investigation of ./jcpan -t Perl::Tidy (v20260204) identified 5 blockers: 1. DESTROY singleton (Critical): Formatter and Tokenizer use closure counters decremented in DESTROY. Since PerlOnJava does not call DESTROY, the 2nd+ perltidy() call per process dies. Affects 36/44 test files (~555 subtests). Fix: 2-line overlay in Perl/Tidy.pm. 2. Option parsing (Moderate): perltidyrc string ref options (-dac, -bl) not applied. Possibly Getopt::Long negatable boolean handling. 3. Wide char alignment (Low): Unicode display width miscalculation. 4. EOL handling (Low): t/test-eol.t produces no output. 5. DEBUG output (Low): debugfile scalar ref returns undef. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Owner
Author
|
Superseded by #469 which includes this doc commit plus the actual fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigation of
./jcpan -t Perl::Tidy(v20260204) — currently 5/44 test files pass.Blockers Identified
Perl::Tidy::FormatterandPerl::Tidy::Tokenizeruse closure-scoped instance counters decremented inDESTROY(). Since PerlOnJava does not call DESTROY, the counter never resets — the 2nd+perltidy()call per process dies with "Attempt to create more than 1 object". Fix: 2-line overlay adding explicit_decrement_count()calls toPerl/Tidy.pm.perltidyrc => \(e.g.-dac,-bl) are not applied. Likely a Getopt::Long negatable boolean (!) handling issue.t/test-eol.tproduces no output.debugfilescalar ref returns undef.Plan
Phase 1 (DESTROY fix) alone should bring results from 5/44 to ~35/44 files passing.
See
dev/modules/perl_tidy.mdfor full analysis and implementation plan.Test plan
./jcpan -t Perl::Tidyand captured all failuresGenerated with Devin