Skip to content

fix(parser): don't greedily consume new as indirect-object class #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fglock merged 1 commit into from
Apr 27, 2026
+10 −3
Merged

fix(parser): don't greedily consume new as indirect-object class #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/perlonjava/core/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public final class Configuration {
* Automatically populated by Gradle/Maven during build.
* DO NOT EDIT MANUALLY - this value is replaced at build time.
*/
public static final String gitCommitId = "1c27ead97";
public static final String gitCommitId = "a671eccbf";

/**
* Git commit date of the build (ISO format: YYYY-MM-DD).
Expand All @@ -48,7 +48,7 @@ public final class Configuration {
* Parsed by App::perlbrew and other tools via: perl -V | grep "Compiled at"
* DO NOT EDIT MANUALLY - this value is replaced at build time.
*/
public static final String buildTimestamp = "Apr 27 2026 20:14:07";
public static final String buildTimestamp = "Apr 27 2026 20:46:44";

// Prevent instantiation
private Configuration() {
Expand Down
9 changes: 8 additions & 1 deletion src/main/java/org/perlonjava/frontend/parser/SubroutineParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,14 @@ && isValidIndirectMethod(subName, parser)
if ((isPackage != null && !isPackage)
|| (isPackage == null && !isKnownSub && token.text.equals("(") && !packageName.contains("::") && subExists)
|| (subExists && packageName.contains("::") && token.text.equals("(")
&& !(isPackage != null && isPackage))) {
&& !(isPackage != null && isPackage))
// If packageName is not a known class and the next token is itself a
// bareword identifier, then `packageName` is more likely a method name
// (e.g. `new`) rather than a class — and the inner `packageName IDENT`
// pair is the real indirect-object call. So reject the outer form.
// Example: `myfunc new Foo (4,5)` should parse as `myfunc(Foo->new(4,5))`,
// NOT as `new->myfunc(Foo(4,5))`.
|| (isPackage == null && !isKnownSub && token.type == LexerTokenType.IDENTIFIER)) {
parser.tokenIndex = currentIndex2;
} else {
// Not a known subroutine, check if it's valid indirect object syntax
Expand Down
Loading