Skip to content

fix: viewer バグ修正（useEffect 依存配列 / null-eventId 挙動統一） #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max747 merged 3 commits into from
Feb 20, 2026
Merged

fix: viewer バグ修正（useEffect 依存配列 / null-eventId 挙動統一） #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e480a63
fix: EventItemSummaryPage の useEffect 依存配列を修正
max747 Feb 20, 2026
6ab00cb
fix: ReportersPage の null-eventId 時の挙動を Navigate に統一
max747 Feb 20, 2026
94f68e0
fix: EventItemSummaryPage の null-eventId 時の挙動を Navigate に統一
max747 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions viewer/src/pages/EventItemSummaryPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ export function EventItemSummaryPage() {
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);

const event = events.find((e) => e.eventId === eventId);

useEffect(() => {
if (!eventId) return;
const event = events.find((e) => e.eventId === eventId);
if (!event) return;
Comment on lines 19 to 22
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

events.find(...) for the selected event is duplicated (once inside the effect and again during render). To avoid the two lookups drifting and to keep the hook deps simple, consider deriving event once (e.g., via useMemo keyed by [events, eventId]) and reusing it in both the effect and the render guard.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

@max747 max747 Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご指摘ありがとうございます。二重呼び出しは冗長ですが、このPRのスコープは最小限に保ちます。EventItemSummaryPage は別PR(#11)で useFetchData フックへ完全にリファクタリングされるため、ここで useMemo を追加するのは過渡的な変更になります。


const controller = new AbortController();
Expand Down Expand Up @@ -57,9 +57,10 @@ export function EventItemSummaryPage() {
if (!controller.signal.aborted) setLoading(false);
});
return () => controller.abort();
}, [event, exclusions]);
}, [eventId, events, exclusions]);

if (!eventId) return null;
if (!eventId) return <Navigate to="/" replace />;
const event = events.find((e) => e.eventId === eventId);
if (!event) return <Navigate to="/" replace />;
if (loading || error) return <LoadingError loading={loading} error={error} />;

Expand Down
2 changes: 1 addition & 1 deletion viewer/src/pages/ReportersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function ReportersPage() {
const { eventId } = useParams<{ eventId: string }>();
const { events, exclusions } = useOutletContext<LayoutContext>();

if (!eventId) return null;
if (!eventId) return <Navigate to="/" replace />;

const event = events.find((e) => e.eventId === eventId);
if (!event) return <Navigate to="/" replace />;
Expand Down