Refresh Test Infrastructure and Expand Coverage to all Specified/Required Behaviours (which currently exist)#32
Draft
dev28237582 wants to merge 8 commits into
Draft
Refresh Test Infrastructure and Expand Coverage to all Specified/Required Behaviours (which currently exist)#32dev28237582 wants to merge 8 commits into
dev28237582 wants to merge 8 commits into
Conversation
added 6 commits
February 18, 2021 11:03
…stand Child recursion in ARHQ
dev28237582
changed the title
dev28237582
commented
Feb 18, 2021
| @@ -0,0 +1,66 @@ | |||
| require 'rails_helper' | |||
|
|
|||
| RSpec.describe Node do | |||
Collaborator
Author
There was a problem hiding this comment.
reload is used everywhere in here because n_children, n_descendants, etc. are calculated by a database trigger (on insert only) - we need to find some way to dirty track these attributes more elegantly than asking a user to reload the model directly every time - a sure path to inconsistent behaviour and bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce best practice tooling such as RSpec and FactoryBot in order to clean up and make test suite more reliable and easier to extend.