Skip to content

fix: guard against division by zero in helper_fdr_peaks_by_fire_elements #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrvollger merged 1 commit into from
Apr 1, 2026
+2 −3
Merged

fix: guard against division by zero in helper_fdr_peaks_by_fire_elements #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions workflow/rules/fire-peaks.smk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ rule helper_fdr_peaks_by_fire_elements:
| bioawk -tc hdr '(NR==1)||($is_local_max=="true")' \
| csvtk filter -tT -C '$' -f "FDR<={params.max_peak_fdr}" \
| csvtk filter -tT -C '$' -f "fire_coverage>1" \
| bioawk -tc hdr '(NR==1)||($fire_coverage/$coverage>={params.min_per_acc_peak})' \
| bioawk -tc hdr '(NR==1)||(NF>0 && $fire_coverage/$coverage>={params.min_per_acc_peak})' \
| bedtools intersect -wa -wb -sorted -a - \
-b <(tabix {input.fire} {wildcards.chrom} \
| cut -f 1-3 \
Expand Down Expand Up @@ -295,8 +295,7 @@ rule wide_fire_peaks:
( \
bgzip -cd {input.bed}; \
bioawk -tc hdr 'NR==1 || $FDR<={params.max_peak_fdr}' {input.track} \
| bioawk -tc hdr 'NR==1 || $coverage>0' \
| bioawk -tc hdr 'NR==1 || ($fire_coverage/$coverage>={params.min_frac_acc})' \
| bioawk -tc hdr 'NR==1 || (NF>0 && $coverage>0 && $fire_coverage/$coverage>={params.min_frac_acc})' \
) \
| cut -f 1-3 \
| bedtools sort \
Expand Down
Loading