Fixes for Paint View / X-Ray View switching anomalies#53
Open
PartySausage wants to merge 2 commits intofieldOfView:masterfrom
Open
Fixes for Paint View / X-Ray View switching anomalies#53PartySausage wants to merge 2 commits intofieldOfView:masterfrom
PartySausage wants to merge 2 commits intofieldOfView:masterfrom
Conversation
If the Paint Tool is active & X-Ray View is selected then the interface now returns to the Paint View when X-Ray View is deselected rather than the Solid View even though the Paint Tool panel remained open. If the Paint Tool is active & X-Ray View is selected then the X-Ray View Legend is now displayed rather than disappearing. The disappearing legend persisted in both X-Ray View & Solid View even if the Paint Tool was subsequently exited. The only way I found to display it again was to toggle to Preview & back to Prepare again, which seemed to force a refresh of the code for displaying the legend When the Paint Tool is active the legend now displays 'Paint Tool' rather than the legend colours for the Solid View, which it would otherwise do after resolving 2 above. The Paint Tool colours are pretty much self explanatory in the plugin panel anyhow & I didn't think there was a reason to include them in the legend too Removed some Paint Tool switching code that was causing delays activating the Paint tool, which didn't deem to have a function or affect operation when removed Corrected case of text in Solid View / X-Ray View Legend
If the Paint Tool is active & X-Ray View is selected then the interface now returns to the Paint View when X-Ray View is deselected rather than the Solid View even though the Paint Tool panel remained open. If the Paint Tool is active & X-Ray View is selected then the X-Ray View Legend is now displayed rather than disappearing. The disappearing legend persisted in both X-Ray View & Solid View even if the Paint Tool was subsequently exited. The only way I found to display it again was to toggle to Preview & back to Prepare again, which seemed to force a refresh of the code for displaying the legend When the Paint Tool is active the legend now displays 'Paint Tool' rather than the legend colours for the Solid View, which it would otherwise do after resolving 2 above. The Paint Tool colours are pretty much self explanatory in the plugin panel anyhow & I didn't think there was a reason to include them in the legend too Removed some Paint Tool switching code that was causing delays activating the Paint tool, which didn't deem to have a function or affect operation when removed Corrected case of text in Solid View / X-Ray View Legend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following legend & view mode anomalies when switching between the Paint Tool & X-Ray View.
If the Paint Tool is active & X-Ray View is selected then the interface now returns to the Paint View when X-Ray View is deselected rather than the Solid View even though the Paint Tool panel remained open.
If the Paint Tool is active & X-Ray View is selected then the X-Ray View Legend is now displayed rather than disappearing. The disappearing legend persisted in both X-Ray View & Solid View even if the Paint Tool was subsequently exited. The only way I found to display it again was to toggle to Preview & back to Prepare again, which seemed to force a refresh of the code for displaying the legend
When the Paint Tool is active the legend now displays 'Paint Tool' rather than the legend colours for the Solid View, which it would otherwise do after resolving 2 above. The Paint Tool colours are pretty much self explanatory in the plugin panel anyhow & I didn't think there was a reason to include them in the legend too
Removed some Paint Tool switching code that was causing delays activating the Paint tool, which didn't deem to have a function or affect operation when removed
Correct case of text in Solid View / X-Ray View Legend
This is my first attempt at creating a PR so hopefully I've followed the correct process