Refresh app package README#9
Conversation
|
Someone is attempting to deploy a commit to the Fielding Johnston's projects Team on Vercel. A member of the Team first needs to authorize it. |
fielding
left a comment
There was a problem hiding this comment.
Thanks for picking up the stale create-next-app boilerplate — this was explicitly flagged in .handoff/CONTEXT.md as scaffold noise to replace. Most of the content checks out (Node 22 / Node 24 SSR caveat, env vars, zero-address treasury behavior, framework versions, "no custom custody contracts" all match the code and decisions docs).
One factual fix and one nit before merge.
Fix: Misleading "Main surfaces" pointers
Wallet, chain, and Sablier transaction plumbing is in
lib/and related hooks/components.
src/lib/ actually contains og-image.tsx, fonts/, schedule.ts, errors.ts, retry.ts, analytics.ts — OG card rendering, schedule math, and retry helpers. None of the wallet/chain/tx code lives there. There is also no hooks/ directory. A reader following this pointer will poke around lib/ looking for the approve/lock flow and come up empty.
The actual layout:
- Wallet/chain config →
src/config/(wagmi.ts,chains.ts,contracts.ts,abis.ts) andsrc/providers.tsx - Sablier approve/lock/claim state machines → inline in
src/app/create/page.tsxandsrc/app/vaults/page.tsx
Nit: /vaults is missing from the surfaces list
"Landing and lock creation live under app/" omits the vault dashboard at /vaults, which is a major surface (claim flow, stream queries, share card).
Suggested replacement for the whole "Main surfaces" section
## Main surfaces
- Landing (`/`), lock creation (`/create`), and vault dashboard (`/vaults`) live under `src/app/`.
- Chain config, contract addresses, and wagmi/RainbowKit setup live in `src/config/` and `src/providers.tsx`.
- Sablier approve / lock / claim transaction flows are inline in the `/create` and `/vaults` page components.
- The app uses wagmi, viem, RainbowKit, Tailwind 4, and Next.js 16.Otherwise LGTM — happy to approve once that section is corrected.
Summary
Validation