Add aie-insert-trace-flows pass#19

Draft

fifield wants to merge 3 commits intoevents_proposalfrom

insert-trace-flows

Owner

fifield commented Mar 4, 2026

Add aie-insert-trace-flows pass

Implement new MLIR pass to automatically insert trace packet flows and runtime sequence configuration for AIE trace operations.

Owner Author

fifield commented Mar 4, 2026

depends on Xilinx#2705

github-actions Bot reviewed

View reviewed changes

include/aie/Dialect/AIE/Transforms/AIEPasses.h

Comment on lines +67 to +68

		std::unique_ptr<mlir::OperationPass<DeviceOp>>
		createAIEInsertTraceFlowsPass();

github-actions Bot Mar 4, 2026

[clang-format] _{reported by reviewdog 🐶}

Suggested change

      
            std::unique_ptr<mlir::OperationPass<DeviceOp>>
          
            createAIEInsertTraceFlowsPass();
          
            std::unique_ptr<mlir::OperationPass<DeviceOp>> createAIEInsertTraceFlowsPass();

lib/Dialect/AIE/Transforms/AIETraceToConfig.cpp

+                          if (eventNum) {
+                            startEvent = *eventNum;
+                          } else {
+                            startOp.emitError("unknown broadcast event '") << eventName << "'";

github-actions Bot Mar 4, 2026

[clang-format] _{reported by reviewdog 🐶}

Suggested change

      
                          startOp.emitError("unknown broadcast event '") << eventName << "'";
          
                          startOp.emitError("unknown broadcast event '")
          
                              << eventName << "'";

github-actions Bot reviewed

View reviewed changes

github-actions Bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

black

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 129 in 86ff619

interval['start'] + interval['duration'] / 2,

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 131 to 133 in 86ff619

    
           event_name.replace('INSTR_', '').replace('DMA_', '').replace('_', ' '), 
        
           ha='center', 
        
           va='center',

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 135 to 136 in 86ff619

    
           weight='bold', 
        
           clip_on=True

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 138 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 142 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 149 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 151 to 154 in 86ff619

    
           ax.set_xlabel('Time (cycles)', fontsize=10) 
        
           ax.set_title(title, fontsize=12, weight='bold') 
        
           ax.grid(True, axis='x', alpha=0.3)

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 158 to 159 in 86ff619

	event_counts[interval['name']] += 1

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 167 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 171 in 86ff619

loc='upper left',

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 174 in 86ff619

framealpha=0.9

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 176 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 179 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 181 in 86ff619

plt.savefig(output_file, dpi=150, bbox_inches='tight')

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 183 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 188 to 190 in 86ff619

    
           print(f"  Time range: {min(i['start'] for i in intervals)} - {max(i['end'] for i in intervals)} cycles") 
        
           print(f"  Duration: {max(i['end'] for i in intervals) - min(i['start'] for i in intervals)} cycles")

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 195 in 86ff619

def main():

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 197 in 86ff619

description='Visualize trace JSON data as a PNG timeline'

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 200 to 202 in 86ff619

    
           '-i', '--input', 
        
           default='trace_mlir.json', 
        
           help='Input trace JSON file (default: trace_mlir.json)'

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 205 to 207 in 86ff619

    
           '-o', '--output', 
        
           default='trace_timeline.png', 
        
           help='Output PNG file (default: trace_timeline.png)'

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 210 to 212 in 86ff619

    
           '-t', '--title', 
        
           default='MLIR Trace Timeline', 
        
           help='Chart title (default: MLIR Trace Timeline)'

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 214 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 216 in 86ff619

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Lines 219 to 221 in 86ff619

    
           print(f"Found {len(processes)} processes, {len(threads)} threads, {len(events)} events")

[black] _{reported by reviewdog 🐶}

mlir-aie/mlir_autotrace_example/visualize_trace.py

Line 224 in 86ff619

if __name__ == '__main__':

mlir_autotrace_example/visualize_trace.py

@@ @@ -0,0 +1,225 @@ @@
+              #!/usr/bin/env python3
+              ##===- visualize_trace.py -----------------------------------------------===##
+              #

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

+              # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+              #
+              # Copyright (C) 2025, Advanced Micro Devices, Inc.
+              #

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

+              import matplotlib.patches as mpatches
+              from collections import defaultdict
+              def parse_trace_json(trace_file):

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
            def parse_trace_json(trace_file):
          
            def parse_trace_json(trace_file):

mlir_autotrace_example/visualize_trace.py

+              def parse_trace_json(trace_file):
+                  """Parse the trace JSON file and extract events."""
+                  with open(trace_file, 'r') as f:

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                with open(trace_file, 'r') as f:
          
                with open(trace_file, "r") as f:

mlir_autotrace_example/visualize_trace.py

+                  """Parse the trace JSON file and extract events."""
+                  with open(trace_file, 'r') as f:
+                      data = json.load(f)

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

Comment on lines +115 to +116

		(interval['start'], lane - 0.4),
		interval['duration'],

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                        (interval['start'], lane - 0.4),
          
                        interval['duration'],
          
                        (interval["start"], lane - 0.4),
          
                        interval["duration"],

mlir_autotrace_example/visualize_trace.py

+                          interval['duration'],
+.8,
+                          facecolor=color,
+                          edgecolor='black',

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                        edgecolor='black',
          
                        edgecolor="black",

mlir_autotrace_example/visualize_trace.py

+                          facecolor=color,
+                          edgecolor='black',
+                          linewidth=0.5,
+                          alpha=0.7

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

+                          alpha=0.7
+                      )
+                      ax.add_patch(rect)

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

+                      # Add text label if duration is large enough (relative to visible range)
+                      label_threshold = time_range / 100  # Show label if event is > 1% of total time
+                      if interval['duration'] > label_threshold:

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                    if interval['duration'] > label_threshold:
          
                    if interval["duration"] > label_threshold:

github-actions Bot reviewed

View reviewed changes

mlir_autotrace_example/visualize_trace.py

+                      label_threshold = time_range / 100  # Show label if event is > 1% of total time
+                      if interval['duration'] > label_threshold:
+                          ax.text(
+                              interval['start'] + interval['duration'] / 2,

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                            interval['start'] + interval['duration'] / 2,
          
                            interval["start"] + interval["duration"] / 2,

mlir_autotrace_example/visualize_trace.py

Comment on lines +131 to +133

+                              event_name.replace('INSTR_', '').replace('DMA_', '').replace('_', ' '),
+                              ha='center',
+                              va='center',

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                            event_name.replace('INSTR_', '').replace('DMA_', '').replace('_', ' '),
          
                            ha='center',
          
                            va='center',
          
                            event_name.replace("INSTR_", "").replace("DMA_", "").replace("_", " "),
          
                            ha="center",
          
                            va="center",

mlir_autotrace_example/visualize_trace.py

Comment on lines +135 to +136

		weight='bold',
		clip_on=True

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                            weight='bold',
          
                            clip_on=True
          
                            weight="bold",
          
                            clip_on=True,

mlir_autotrace_example/visualize_trace.py

+                              weight='bold',
+                              clip_on=True
+                          )

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

+                  # Set up axes
+                  ax.set_ylim(-0.5, lane_idx - 0.5)
+                  ax.set_yticks(range(lane_idx))

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

Comment on lines +210 to +212

+                      '-t', '--title',
+                      default='MLIR Trace Timeline',
+                      help='Chart title (default: MLIR Trace Timeline)'

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                    '-t', '--title',
          
                    default='MLIR Trace Timeline',
          
                    help='Chart title (default: MLIR Trace Timeline)'
          
                    "-t",
          
                    "--title",
          
                    default="MLIR Trace Timeline",
          
                    help="Chart title (default: MLIR Trace Timeline)",

mlir_autotrace_example/visualize_trace.py

+                      default='MLIR Trace Timeline',
+                      help='Chart title (default: MLIR Trace Timeline)'
+                  )

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

		)

		args = parser.parse_args()

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

mlir_autotrace_example/visualize_trace.py

Comment on lines +219 to +221


		print(f"Found {len(processes)} processes, {len(threads)} threads, {len(events)} events")

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
                print(f"Found {len(processes)} processes, {len(threads)} threads, {len(events)} events")
          
                print(
          
                    f"Found {len(processes)} processes, {len(threads)} threads, {len(events)} events"
          
                )

mlir_autotrace_example/visualize_trace.py


		create_timeline(processes, threads, events, args.output, args.title)

		if __name__ == '__main__':

github-actions Bot Mar 4, 2026

[black] _{reported by reviewdog 🐶}

Suggested change

      
            if __name__ == '__main__':
          
            if __name__ == "__main__":

fifield force-pushed the insert-trace-flows branch from 7fcea46 to d580aba Compare

March 4, 2026 21:21

fifield added 3 commits

March 4, 2026 14:27


          test trace ops python binding; update example to set device in makefile

5f22f52


          Add aie-insert-trace-flows pass

c471d53

Implement new MLIR pass to automatically insert trace packet flows and
runtime sequence configuration for AIE trace operations.

Features:
- Creates packet flows from trace ports to shim DMA channels
- Supports core and mem trace types with correct port assignment
- Minimizes shim tile usage by routing multiple traces to same shim
- Allocates packet IDs automatically if not specified
- Inserts runtime sequence operations for trace setup (timer control,
  BD config, DMA setup, broadcast generation)
- Configurable options for shim channel, BD ID, packet ID, buffer size

Tests:
- test_insert_trace_flows_simple.mlir: Single core trace
- test_insert_trace_flows_multiple.mlir: Multiple traces (core + mem)
  from different tiles routing to one shim


          update test

a2748ea

fifield force-pushed the insert-trace-flows branch from d580aba to a2748ea Compare

March 4, 2026 21:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet