Skip to content

Improve handling of temporary path #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitsmanent wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve handling of temporary path #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da9adc0
Honor prefix if specified and ensure paths exists.
bitsmanent Jan 19, 2026
5e793fb
Improve handling of temp path.
bitsmanent Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions get.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,26 @@
install_filemanager()
{
trap 'echo -e "Aborted, error $? in command: $BASH_COMMAND"; trap ERR; return 1' ERR

# defaults to /usr/local
[[ -z "$PREFIX" ]] && PREFIX="/usr/local"

filemanager_os="unsupported"
filemanager_arch="unknown"
install_path="/usr/local/bin"
install_path="$PREFIX/bin"
temp_path="/tmp"

# Termux on Android has $PREFIX set which already ends with /usr
if [[ -n "$ANDROID_ROOT" && -n "$PREFIX" ]]; then
install_path="$PREFIX/bin"
fi

# Fall back to /usr/bin if necessary
if [[ ! -d $install_path ]]; then
install_path="/usr/bin"
fi
# Use $PREFIX for compatibility with Termux on Android
[[ -n "$ANDROID_ROOT" ]] && temp_path="$PREFIX/tmp"

# Not every platform has or needs sudo (https://termux.com/linux.html)
((EUID)) && [[ -z "$ANDROID_ROOT" ]] && sudo_cmd="sudo"

# ensure directories exists
[[ ! -d "$PREFIX" ]] && mkdir -p "$PREFIX"
[[ ! -d "$install_path" ]] && mkdir -p "$install_path"
[[ ! -d "$temp_path" ]] && mkdir -p "$temp_path"

#########################
# Which OS and version? #
#########################
Expand Down Expand Up @@ -105,30 +108,29 @@ install_filemanager()
echo "Aborted, could not find curl or wget"
return 7
fi

filemanager_file="${filemanager_os}-$filemanager_arch-filebrowser$filemanager_dl_ext"
filemanager_tag="$(${net_getter} https://api.github.com/repos/filebrowser/filebrowser/releases/latest | grep -o '"tag_name": ".*"' | sed 's/"//g' | sed 's/tag_name: //g')"
filemanager_url="https://github.com/filebrowser/filebrowser/releases/download/$filemanager_tag/$filemanager_file"
echo "$filemanager_url"

# Use $PREFIX for compatibility with Termux on Android
rm -rf "$PREFIX/tmp/$filemanager_file"
rm -rf "$temp_path/$filemanager_file"

${net_getter} "$filemanager_url" > "$PREFIX/tmp/$filemanager_file"
${net_getter} "$filemanager_url" > "$temp_path/$filemanager_file"

echo "Extracting..."
case "$filemanager_file" in
*.zip) unzip -o "$PREFIX/tmp/$filemanager_file" "$filemanager_bin" -d "$PREFIX/tmp/" ;;
*.tar.gz) tar --no-same-owner -xzf "$PREFIX/tmp/$filemanager_file" -C "$PREFIX/tmp/" "$filemanager_bin" ;;
*.zip) unzip -o "$temp_path/$filemanager_file" "$filemanager_bin" -d "$temp_path/" ;;
*.tar.gz) tar --no-same-owner -xzf "$temp_path/$filemanager_file" -C "$temp_path/" "$filemanager_bin" ;;
esac
chmod +x "$PREFIX/tmp/$filemanager_bin"
chmod +x "$temp_path/$filemanager_bin"

echo "Putting filemanager in $install_path (may require password)"
$sudo_cmd mv "$PREFIX/tmp/$filemanager_bin" "$install_path/$filemanager_bin"
$sudo_cmd mv "$temp_path/$filemanager_bin" "$install_path/$filemanager_bin"
if setcap_cmd=$(PATH+=$PATH:/sbin type -p setcap); then
$sudo_cmd $setcap_cmd cap_net_bind_service=+ep "$install_path/$filemanager_bin"
fi
$sudo_cmd rm -- "$PREFIX/tmp/$filemanager_file"
$sudo_cmd rm -- "$temp_path/$filemanager_file"

if type -p $filemanager_bin >/dev/null 2>&1; then
echo "Successfully installed"
Expand Down