Fixed an issue where file thumbnails failed to appear after saving a …#18466
Open
workbysaran wants to merge 1 commit into
Open
Fixed an issue where file thumbnails failed to appear after saving a …#18466workbysaran wants to merge 1 commit into
workbysaran wants to merge 1 commit into
Conversation
…file such as using Chrome "Save as PDF", Adobe PDF printer, or Microsoft PDF printer.
yair100
reviewed
May 10, 2026
Member
There was a problem hiding this comment.
Overall looks good, can you please add some code comments?
There was a problem hiding this comment.
The situation is not improving. I have absolutely no idea why.
Files 4.1.0.0
Member
There was a problem hiding this comment.
@yamachari2025-ops if you're using v4.1, this hasn't been released yet. Did you build the source code for this PR?
There was a problem hiding this comment.
I'm sorry. I'm not a programmer, I'm just a user.
Member
There was a problem hiding this comment.
No problem, hopefully this PR fixes the issue for the next release. If not, make sure to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where file thumbnails failed to appear after saving a file using Chrome "Save as PDF", Adobe PDF printer, or Microsoft PDF printer.
This fix adds a 2-second timer-based self-retry directly in LoadThumbnailAsync as a fallback for when no FILE_ACTION_MODIFIED event follows a thumbnail failure. Diagnostic logging also added to investigate the issue.
Closes #18352
Steps used to test these changes