Fix: BitLocker locked drive not shown#18468
Open
muko wants to merge 1 commit into
Open
Conversation
8a44aaf to
0e96df1
Compare
d2dyno1
suggested changes
May 12, 2026
| { | ||
| var driveAdded = new DriveInfo(e.DeviceId); | ||
| if (!driveAdded.IsReady) | ||
| if (!driveAdded.IsReady && !IsUnauthorizedDrive(driveAdded)) |
Member
There was a problem hiding this comment.
I think this should be "or" condition (||).
If the drive is not ready, IsUnauthorizedDrive will still be called, causing an exception on an unready drive
| // Check if this drive is associated with a drive letter | ||
| var driveAdded = new DriveInfo(root.Path); | ||
| if (!driveAdded.IsReady) | ||
| if (!driveAdded.IsReady && !IsUnauthorizedDrive(driveAdded)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
This PR fixes an issue where locked BitLocker drives were not shown.
Note: This PR updates only
WindowsStorageDeviceWatcher; however, commit 6674a8f also changesStorageDeviceServices.Steps used to test these changes