fix(web,hub): resolve all REVIEW.md findings (6 warnings + 7 info)#185
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 13 findings from the 2026-05-29 session code review (.planning/audits/2026-05-29-session-REVIEW.md). 0 Critical were found; this clears the 6 Warnings + 7 Info.
Warnings: WR-01 signOut latch (idempotent on concurrent 401s); WR-02 unlink resets telegram_default_explicit; WR-03 window.open noopener,noreferrer; WR-04 unmount guards on TelegramCard/OrchestratorTab async effects; WR-05 OrchestratorTab failed-load → EmptyState+Retry (not infinite Loading) + surface action errors; WR-06 synthetic orchestrator row counted against the 200 cap.
Info: removed mount/unmount console.logs (5 tabs); useProfile setLoading(false) on null token; pure getRoute() init; dropped dead launchSession prop; conditional 🟢 legend; pickLargestPhoto empty guard; skip redundant default-session write for orchestrator users.
Auth-hardening from #180–#182 preserved (WR-01 latch keeps signOut idempotent AND firing). tsc 0, build 0, touched telegram suites green, check-baseline unchanged vs base (the lone migrate-users fail is a pre-existing local-env JWT_SECRET artifact).
🤖 Generated with Claude Code