change(ci): remove our customizations to semantic pr title requirements#1013
Merged
Conversation
Signed-off-by: Eddie Knight <knight@linux.com>
✅ Deploy Preview for common-cloud-controls canceled.
|
eddie-knight
changed the title
eddie-knight
changed the title
sshiells-scottlogic
approved these changes
May 28, 2026
Contributor
smendis-scottlogic
left a comment
smendis-scottlogic
left a comment
There was a problem hiding this comment.
Now it has defaulted to use conventional commits format right?
Shouldn't we document how the titles should look like now since it still ask for specific types such as
feat → new feature
fix → bug fix
docs → documentation
chore → maintenance
refactor → code restructuring
test → tests
ci → CI/CD changes
Signed-off-by: Eddie Knight <knight@linux.com>
Collaborator
Author
|
Good point @smendis-scottlogic — I added a PR template so that everyone is reminded of the reqs at the time it actually matters. |
gbalysevaite
pushed a commit
to gbalysevaite/common-cloud-controls
that referenced
this pull request
Jun 2, 2026
…ts (finos#1013) Signed-off-by: Eddie Knight <knight@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got creative a while back and tried customizing the PR title requirements, but the customized requirements never became habit or intuitive even for maintainers. This restores the normal semantic pr title requirements (ci, feat, docs, fix, etc)