adding switch and new types - #4962
Open
stevenjblum wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
second attempt at merging new types and switch statement |
gs-jp1
reviewed
Jul 21, 2026
| import org.finos.legend.engine.plan.execution.stores.relational.activity.AggregationAwareActivity; | ||
| import org.finos.legend.engine.plan.execution.stores.relational.activity.RelationalExecutionActivity; | ||
| import org.finos.legend.engine.plan.execution.stores.relational.result.RelationalResult; | ||
| import org.finos.legend.engine.plan.execution.stores.relational.result.ResultInterpreterExtension; |
Contributor
There was a problem hiding this comment.
as discussed, lets add to the additional tests to cover all types in follow up
gs-jp1
previously approved these changes
Jul 21, 2026
gs-opensource-bot
force-pushed
the
review-arrow-new-types2
branch
from
July 21, 2026 19:06
b6c54f1 to
6f829c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?