fix: nested list item fields detection#787
Merged
alexiglesias93 merged 1 commit intomasterfrom Apr 16, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect classification of list item fields as “nested” by changing the nested-list detection logic to only treat fields as nested when their closest CMS “list” element is actually contained within the current list item (i.e., truly nested inside it). This prevents false positives that could break filtering.
Changes:
- Update nested list detection in
ListItem.collectFields()to use DOM containment (this.element.contains(parentList)) instead of comparing against the current list element. - Add a changeset to publish a patch release for
@finsweet/attributes-list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/list/src/components/ListItem.ts | Adjusts nested-field detection to avoid misclassifying fields as nested, improving filtering correctness. |
| .changeset/short-numbers-itch.md | Declares a patch release with a brief changelog entry for the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 16, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the fields were being mistakenly detected as nested, causing filtering issues.