Fix restart handoff convergence on main#153
Merged
Merged
Conversation
Accept a running app process as current when it is executing the active app binary and the node-local Surge update status is converged for the selected version. The previous probe required transient --surge-first-run command-line proof, so package-current force installs could restart successfully and still fail verification after the supervisor switched to its normal watch command. Validated with the focused surge-cli process verification tests and a live package-current force install against selsbakk-master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.Root Cause
The previous
mainline could leave.surge-update-status.jsonatpending_restartafter the target child was already running. The newest targeted fixes existed onfix/restart-convergence-proof, but the latermainbeta line did not include them.Validation
cargo test -p surge-supervisor handoffcargo test -p surge-ffi self_supervisor_converges_pending_status_when_runtime_manifest_matchescargo test -p surge-cli build_remote_process_verification_probe./scripts/sync-surge-core-vendor.sh --check./scripts/check-version-sync.shcargo fmt --all -- --checkRUSTFLAGS="-D warnings" cargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_usedcargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedanticdotnet format dotnet/Surge.slnx --verify-no-changesdotnet test dotnet/Surge.slnx --configuration Release