Skip to content

refactor: email sign-in opt-in, remove providerButton closure#1252

Merged
russellwheatley merged 5 commits into
mainfrom
opt-in-email-provider
May 20, 2025
Merged

refactor: email sign-in opt-in, remove providerButton closure#1252
russellwheatley merged 5 commits into
mainfrom
opt-in-email-provider

Conversation

@russellwheatley

@russellwheatley russellwheatley commented May 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Allow users to opt-in for email provider sign-in.
  • Removed the providerButton closure on AuthPickerView.

Question

  • If the user doesn't opt-in for email provider sign-in, it will also hide email link sign-in. Presumably that is what we want?

morganchen12
morganchen12 reviewed May 12, 2025
View reviewed changes
Comment thread FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/AuthPickerView.swift Outdated
Comment thread FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/EmailAuthView.swift
morganchen12
morganchen12 approved these changes May 19, 2025
View reviewed changes

@morganchen12 morganchen12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit 0a5962f into main May 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@peterfriese peterfriese Awaiting requested review from peterfriese

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @morganchen12