feat(FirebaseStorageUI): add FirebaseStorageUISwift SPM product for Swift-typed API#1351
Draft
demolaf wants to merge 6 commits into
Draft
feat(FirebaseStorageUI): add FirebaseStorageUISwift SPM product for Swift-typed API#1351demolaf wants to merge 6 commits into
demolaf wants to merge 6 commits into
Conversation
…wift-typed API Adds a new `FirebaseStorageUISwift` SPM library product with a Swift-only target that provides properly-typed `sd_setImageWithStorageReference(_:)` overloads using `StorageReference` directly, so Swift SPM clients no longer need workarounds. Closes #1271
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…on with defaults and simplify storageURL
…rebase Storage 9+
…nd update StorageViewController to use FirebaseStorageUISwift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1271.
Adds
FirebaseStorageUISwift, a Swift-only SPM product that providessd_setImageWithStorageReference(_:)overloads typed onStorageReference. Swift SPM clients canimport FirebaseStorageUISwiftand call the method directly without workarounds.Builds on #1350 — the ObjC headers use
@classforward declarations which fix the Clang scan-phase failure but leaveStorageReferenceopaque to Swift, so this target fills that gap.